Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] TraceableHttpClient: increase decorator's priority#47836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromadpeyre:patch-1
Dec 13, 2022

Conversation

adpeyre
Copy link
Contributor

@adpeyreadpeyre commentedOct 11, 2022•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

Hello,

When I decorate my http client, all requests are not collected and visible in the profiler because of the decorator's priority of TraceableHttpClient (sub request for example). I think it should be increased. I fixed an arbitrary value of 100.

What do you think about that ?

Ty

eolas-app reacted with rocket emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@adpeyreadpeyreforce-pushed thepatch-1 branch 2 times, most recently fromfec41fe toc0c33a3CompareOctober 11, 2022 18:45
@adpeyreadpeyre changed the titleTraceableHttpClient: increase decorator's priority[HttpClient] TraceableHttpClient: increase decorator's priorityOct 11, 2022
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

makes sense to me

@carsonbotcarsonbot changed the title[HttpClient] TraceableHttpClient: increase decorator's priorityTraceableHttpClient: increase decorator's priorityOct 17, 2022
@chalasr
Copy link
Member

chalasr commentedOct 17, 2022•
edited
Loading

Sorry if I'm mistaken, but wouldn't increasing the priority rather make your decorator untraceable? Ref:#47764, looks like we need a policy here

Got it, we don't care as the http-client collector is not about tracing code execution but requests/responses.

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This means we have to adjust the decoration priority ofRetryableHttpClient as well on higher branches:

->setDecoratedService($name,null,10)// higher priority than TraceableHttpClient

which might be more risky BC-wise (see#38633 for background)

@chalasrchalasr modified the milestones:4.4,5.4Nov 22, 2022
@carsonbotcarsonbot changed the titleTraceableHttpClient: increase decorator's priority[HttpClient] TraceableHttpClient: increase decorator's priorityDec 13, 2022
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I set the priority to 5 instead, to account for@chalasr's well spotted comment.

chalasr reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Thank you@adpeyre.

adpeyre reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commita810772 intosymfony:5.4Dec 13, 2022
@fabpotfabpot mentioned this pull requestDec 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chalasrchalasrchalasr requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

4 participants
@adpeyre@carsonbot@chalasr@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp