Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Make HttplugClient implement PSR-17 factories instead of Httplug's#47832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromnicolas-grekas:hc-httplug-no-factory
Oct 15, 2022

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?6.2
Bug fix?no
New feature?no
Deprecations?yes
Tickets-
LicenseMIT
Doc PR-

Nobody usesphp-http/message-factory anyway:
https://packagist.org/packages/php-http/message-factory-implementation/dependents

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@MGatner
Copy link
Contributor

MGatner commentedOct 15, 2022•
edited
Loading

It looks like this addedsymfony/deprecation-contracts to Composer'sprovide key instead ofrequire, which is causing the package not to be installed in some cases because Composer thinks this dependency takes care of it 😢

@fabpotfabpot deleted the hc-httplug-no-factory branchOctober 15, 2022 15:52
@fabpotfabpot mentioned this pull requestOct 24, 2022
@xabbuh
Copy link
Member

FTR, the previous comment was addressed in#47873.

MGatner reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestApr 17, 2023
…(nicolas-grekas)This PR was merged into the 5.4 branch.Discussion----------[ErrorHandler] Don't throw deprecations for HttplugClient| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       |#50035| License       | MIT| Doc PR        | -Followsphp-http/httplug#171 and#47832Required to make the CI green again.Commits-------bafb237 [ErrorHandler] Don't throw deprecations for HttplugClient
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@fabpot@MGatner@xabbuh@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp