Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Fix amqp socket lost#47831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromGurvanVgx:fix-amqp-socket-error
Oct 15, 2022

Conversation

@GurvanVgx
Copy link
Contributor

@GurvanVgxGurvanVgx commentedOct 11, 2022•
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#42825
LicenseMIT
Doc PRN/A

I'm taking the work done from someone else and and adding the remarks mentionned because there is no activity on this PR

PR:#47574

Network can fail in many ways, sometimes pretty subtle.

To avoid error messages "Library error: a socket error occurred", we detect when heartbeat as expired, and disconnect the chanmel connection, and force a reconnect.

Here a explanation to justify the condition :
https://www.rabbitmq.com/heartbeats.html#:~:text=Heartbeat%20frames%20are%20sent%20about,TCP%20connection%20will%20be%20closed.

Tan5en5, filozofer, and ottaviano reacted with heart emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@GurvanVgx
Copy link
ContributorAuthor

I don't understand why test is failing

@nicolas-grekas
Copy link
Member

Failures are unrelated I'd say. Can you please addMiguel Fernandez <mfernandez@nuglif.com> as co-author?

@carsonbotcarsonbot changed the titleFix amqp socket lost[Messenger] Fix amqp socket lostOct 11, 2022
@GurvanVgx
Copy link
ContributorAuthor

Done@nicolas-grekas

Thanks for the review :)

@nicolas-grekasnicolas-grekasforce-pushed thefix-amqp-socket-error branch 2 times, most recently from415b04a toe64b57aCompareOctober 11, 2022 16:54
Co-authored-by: Miguel Fernandez <mfernandez@nuglif.com>
@fabpot
Copy link
Member

Thank you@GurvanVgx.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@GurvanVgx@carsonbot@nicolas-grekas@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp