Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] fix: use message object from event#47822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedOct 10, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
fabpot commentedOct 15, 2022
Thank you@rogamoore. |
Based on the documentationhttps://symfony.com/doc/current/mailer.html#messageevent
However right now you can do only the following:
But you cannot replace the Message object, even if there is a method
setMessageon the event.The reason is that the AbstractTransport does get the updated/replaced Envelope object from the event, but not the Message object:
So why would we need to replace the Message object in the first place?
One example would be the signing of messages (see example herehttps://symfony.com/doc/current/mailer.html#dkim-signer) in a listener. The signer does not modify the existing Message object, but returns a new instance. If we then use
$event->setMessage($signedEmail)it simply doesn't work, because it's going to be ignored in the transport.See also this comment here, where someone encountered the same issue:#39354 (comment)