Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] TraceableAccessDecisionManager: fix inspecting voters of custom access decision managers#47817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Security/Core/Authorization/TraceableAccessDecisionManager.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not a bug per se though, I'd say this should be merged in 6.2.
I couldn't decide initially if it should be suggested as a bug or feature, but it looks more like an improvement. Do you think I should create another PR for 6.2 too? I think it has been said that merges to older tags would be merged to newer ones in a few days. |
No worry, we can switch the branch while merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍🏻 for 6.2
…ustom access decision managers
Thank you@sarbanha. |
Removed the "if" statement that verifies if the ADM is instance of AccessDecisionManager.
This control breaks profiler when it is trying to browse "Security" tab while a custom ADM was developed. The reason is that the "if" statement prevents SecurityDataCollector.php to retrieve the strategy and the list of voters.
Based on my tests this modification doesn't affect the regular functionality of security-core.