Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] sync message serializer code for forward-compatibility#47753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromxabbuh:pr-47462-6.1
Oct 2, 2022

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedOct 1, 2022•
edited by fabpot
Loading

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

@xabbuh
Copy link
MemberAuthor

Before continuing here we should IMO discuss whether or not the BC promise applies to the serialized message format or if#47462 would introduce a BC break.

ping@fabpot

@fabpot
Copy link
Member

As the removed information was never used anyway, I think it's safe.

@xabbuh
Copy link
MemberAuthor

@fabpot I think I need to look into this a bit more. Thedeps=low job shouldn’t fail. I’ll take care of this later today.

@xabbuhxabbuh mentioned this pull requestOct 1, 2022
@xabbuhxabbuhforce-pushed thepr-47462-6.1 branch 2 times, most recently from9885be3 to31f2680CompareOctober 1, 2022 17:15
@xabbuhxabbuhforce-pushed thepr-47462-6.1 branch 2 times, most recently from906e4ee to8f1683aCompareOctober 1, 2022 17:22
@xabbuhxabbuh changed the base branch from6.1 to5.4October 1, 2022 17:22
@xabbuhxabbuh modified the milestones:6.1,5.4Oct 1, 2022
@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commitac0b415 intosymfony:5.4Oct 2, 2022
@xabbuhxabbuh deleted the pr-47462-6.1 branchOctober 2, 2022 07:59
This was referencedOct 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp