Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfiler] Fix overflow issue in Forms panel#47731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromzolikonta:4.4
Oct 1, 2022
Merged

[WebProfiler] Fix overflow issue in Forms panel#47731

fabpot merged 1 commit intosymfony:4.4fromzolikonta:4.4
Oct 1, 2022

Conversation

@zolikonta
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsno
LicenseMIT
Doc PRno

Fix overflow issue in WebProfiler Forms panel

Hides overflowing content in the tree view and adds ellipsis to the end.
Also adds title attribute with the field names so they get shown fully on hover.

Before:
Screenshot 2022-09-29 at 15-49-43 Symfony Profiler
After:
Screenshot 2022-09-29 at 15-49-44 Symfony Profiler

You might want to consider widening#tree-menu especially inwidth-full.

This PR applies to 4.4 and 5.4 branch as well not sure about 6.2 though I noticed a redesign but haven't got the chance to check it out.

Thank you

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@zolikontazolikonta marked this pull request as ready for reviewSeptember 29, 2022 14:36
@carsonbotcarsonbot added this to the4.4 milestoneSep 29, 2022
@zolikontazolikonta changed the titleFix overflow issue in WebProfiler Forms panel[WebProfiler] Fix overflow issue in Forms panelSep 30, 2022
Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@zolikonta!

About the 6.2 redesign: yes, let's merge this up to that branch and later we can tweak/fix things as needed.

zolikonta reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@zolikonta.

zolikonta reacted with thumbs up emoji

@fabpotfabpot merged commit289d6b4 intosymfony:4.4Oct 1, 2022
This was referencedOct 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@zolikonta@carsonbot@fabpot@javiereguiluz

[8]ページ先頭

©2009-2025 Movatter.jp