you should not mark this PR is fixing the issue, as it only does part of the work. We don't want the issue to get closed automatically by github when only that PR is merged. So having a link to the issue is good, but you should not haveFix before it.

Note: I edited the PR description to remove it, but please be careful about that for your next PRs

you should not mark this PR is fixing the issue, as it only does part of the work. We don't want the issue to get closed automatically by github when only that PR is merged. So having a link to the issue is good, but you should not haveFix before it.

Note: I edited the PR description to remove it, but please be careful about that for your next PRs

thanks for for it@stof, I wasn't aware of this.

This component is still usingdate_create, which needs to be migrated todate_create_immutable instead

Nice catch thanks !

@WebMamba looks like I miunderstood what you meant by "I'll process component by component", as it seems like you are adding other components in the same PR (which would invalidate my previous approval as it was only for BrowserKit).

If you want us to review it component by component, separate PRs would be a better fit.

@WebMamba looks like I miunderstood what you meant by "I'll process component by component", as it seems like you are adding other components in the same PR (which would invalidate my previous approval as it was only for BrowserKit).

If you want us to review it component by component, separate PRs would be a better fit.

@nicolas-grekas asked me to process it like this. I do all the easy changes here and if we spot a tricky one we do a dedicated PR

Thanks,@stof for your review! All the things you spotted are corrected now! 👍

Thank you@WebMamba.