Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
catch \Throwable instead of \Exception#47708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedSep 27, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
stof commentedSep 27, 2022
New features are never backported to previous minor versions |
unixslayer commentedSep 27, 2022
@stof this is not backported feature. When |
derrabus commentedSep 27, 2022
Your PR would introduce a breaking change into an LTS branch. The change you're suggesting has been implemented in a backwards-compatible manner in 6.2 via#45997. If you need this change, upgrade to Symfony 6.2. |
pkusmierczyk commentedSep 28, 2022
@derrabus Is it intentional that PHP errors won't be handled by framework until next stable release? Because they are not handled on current LTS which looks more like a bug, not a feature. |
nicolas-grekas commentedSep 28, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
HttpKerneldo not catch\TypeErrors to handle it later usingkernel.exceptionevent which is already implemented insymfony:6.2. According to minimum version of PHP this do not cause BC Breaks.