Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

catch \Throwable instead of \Exception#47708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
unixslayer wants to merge1 commit intosymfony:5.4fromunixslayer:5.4

Conversation

@unixslayer
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

HttpKernel do not catch\TypeErrors to handle it later usingkernel.exception event which is already implemented insymfony:6.2. According to minimum version of PHP this do not cause BC Breaks.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@stof
Copy link
Member

New features are never backported to previous minor versions

@unixslayer
Copy link
ContributorAuthor

@stof this is not backported feature. WhenTypeError is thrown it is impossible to handle it withkernel.exception event. This happens to be fixed on next release but it still remains on LTS.

@derrabus
Copy link
Member

Your PR would introduce a breaking change into an LTS branch. The change you're suggesting has been implemented in a backwards-compatible manner in 6.2 via#45997. If you need this change, upgrade to Symfony 6.2.

@pkusmierczyk
Copy link

@derrabus Is it intentional that PHP errors won't be handled by framework until next stable release? Because they are not handled on current LTS which looks more like a bug, not a feature.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedSep 28, 2022
edited
Loading

Yes it is: this behavior exists since the beginning of Symfony v2 and changing it would break existing apps.
Actually, 6.2 won't change the current behavior if#47467 is merged (and I hope it will)
See#45997 for more background on the topic.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@unixslayer@carsonbot@stof@derrabus@pkusmierczyk@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp