Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer][Mailjet] Apply the default value of 512 for max depths#47703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.1fromnurtext:fix-47701
Sep 29, 2022

Conversation

@nurtext
Copy link
Contributor

QA
Branch?6.1
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#47701
LicenseMIT
Doc PRn/a

Applies the default value of 512 for max depths when using PHP's json_decode() function.

See#47701 for more details.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nurtextnurtext changed the base branch from6.2 to6.1September 27, 2022 11:19
@carsonbotcarsonbot changed the title[symfony/mailjet-mailer] Fix bug #47701[Mailer] [symfony/mailjet-mailer] Fix bug #47701Sep 29, 2022
@OskarStarkOskarStark changed the title[Mailer] [symfony/mailjet-mailer] Fix bug #47701[Mailer][Mailjet] Fix bug #47701Sep 29, 2022
@OskarStarkOskarStark changed the title[Mailer][Mailjet] Fix bug #47701[Mailer][Mailjet] Applies the default value of 512 for max depthsSep 29, 2022
@OskarStark
Copy link
Contributor

I would consider this a bugfix to be merged in6.1 instead of6.2

nurtext reacted with thumbs up emoji

@OskarStarkOskarStark changed the title[Mailer][Mailjet] Applies the default value of 512 for max depths[Mailer][Mailjet] Apply the default value of 512 for max depthsSep 29, 2022
@fabpotfabpot modified the milestones:6.2,6.0,6.1Sep 29, 2022
@fabpot
Copy link
Member

Thank you@nurtext.

nurtext reacted with heart emoji

@fabpotfabpot merged commit3810eaa intosymfony:6.1Sep 29, 2022
@fabpotfabpot mentioned this pull requestSep 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

[symfony/mailjet-mailer] JSON payload for X-MJ-Vars only allows for a max depth of two (2)

4 participants

@nurtext@carsonbot@OskarStark@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp