Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Filter out trans paths that are covered by a parent folder path#47695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@natewiebe13
Copy link

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsPartiallyFixes#45645
LicenseMIT
Doc PRN/A

It was possible to end up with duplicated paths which would could result in many files being scanned more than once. This prevents that.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR. Can you figure out a test case for this please?

@carsonbotcarsonbot changed the titleFilter out trans paths that are covered by a parent folder path[FrameworkBundle] Filter out trans paths that are covered by a parent folder pathSep 28, 2022
@natewiebe13natewiebe13force-pushed theprevent-duplicate-trans-extraction branch from12b311d tobfb8cbeCompareSeptember 28, 2022 14:57
@natewiebe13natewiebe13force-pushed theprevent-duplicate-trans-extraction branch 3 times, most recently from5499355 to3fdcbcaCompareSeptember 28, 2022 15:03
@nicolas-grekas
Copy link
Member

Thank you@natewiebe13.

nicolas-grekas added a commit that referenced this pull requestSep 28, 2022
…by a parent folder path (natewiebe13)This PR was squashed before being merged into the 5.4 branch.Discussion----------[FrameworkBundle] Filter out trans paths that are covered by a parent folder path| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | PartiallyFixes#45645| License       | MIT| Doc PR        | N/AIt was possible to end up with duplicated paths which would could result in many files being scanned more than once. This prevents that.Commits-------459ac04 [FrameworkBundle] Filter out trans paths that are covered by a parent folder path
@nicolas-grekasnicolas-grekasforce-pushed theprevent-duplicate-trans-extraction branch from3fdcbca to459ac04CompareSeptember 28, 2022 15:35
This was referencedSep 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@natewiebe13@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp