Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Deprecate numeric parameter names#47683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f47f3bd to8083245CompareMember
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGMT, just some minor comment
src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
d3af9e4 toe391711Comparenicolas-grekas approved these changesSep 26, 2022
chalasr approved these changesSep 26, 2022
Uh oh!
There was an error while loading.Please reload this page.
e391711 to3e0050aCompareMember
chalasr commentedSep 26, 2022
Thank you@HeahDude. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
While trying to use
'.' !== $key[0]instead ofstr_starts_with($key, '.')in#47680, I noticed some tests were failing due to the usage of numeric parameter names in the fixtures.This leads to inconsistent behavior since the following code:
$parameterBag->set(10, 10), will first cast the name10to string because of the method signature, but will then cast back to integer when using it as an array key inhttps://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php#L89.Because Symfony does not use strict types, it can be really tricky.
This PR propose to deprecate using such names to be able to properly throw in 7.0.