Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfilerBundle] Update the mailer panel#47643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromjaviereguiluz:mailer_panel
Oct 1, 2022

Conversation

@javiereguiluz
Copy link
Member

QA
Branch?6.2
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Related to#47148, this updates one of the panels which weren't updated in that other PR.

Before - 1 email sent

before-1-email

Before - Multiple emails sent

before-multiple-emails

Before - Email attachments

before-attachment

After - 1 email sent

after-1-email

Comments:

  • All email contents are displayed on the same place, to make debugging quicker
  • All headers are displayed too; this can be long in some cases, but I think it's better to display them all to spot errors easier and quicker
  • Attachments now display file name, file size and a link to download them as files. We no longer display the base64-encoded contents of the file

After - Multiple emails sent

after-multiple-emails

Comments:

  • When there's more than 1 email sent/queued, we display the "Email 1", "Email 2", etc. navigation (which is hidden when there's only 1 email to make design more efficient)

After - MIME parts

after-mime-parts

Comments:

  • This is the same as before

After - Raw message

after-raw-message

Comments:

  • We now include a link to download the raw email as a*.eml file

babeuloula, fabstei, deguif, artyuum, raziel057, smnandre, creiner, tigitz, Crovitche-1623, Chris53897, and 4 more reacted with heart emojiHeahDude, OskarStark, tarlepp, and ging-dev reacted with rocket emoji
@stof
Copy link
Member

One thing that seems gone is showing which transport was used for each email (previously, it was shown in the tabs switching between emails)

@stof
Copy link
Member

@javiereguiluz can you share the before/after comparison for how the panel looks like with multiple transports ?

@javiereguiluz
Copy link
MemberAuthor

@stof thanks for the review. About the transport, to reduce the noise I thought it was a good idea to only display the transport if there's more than one transport. This is how it'd look like when showing the transport name:

mailer-transport

But thanks to your comment, I realized that maybe your app defines multiple transports, but this request only used one of them ... so you need the transport info somewhere. What about showing it like this:

mailer-transport-information

Do you know how long can be the transport name in practice? It's the full DNS or a human-friendly short name? Thanks!

@stof
Copy link
Member

IIRC, it is the full DSN (minus the auth part)

javiereguiluz reacted with thumbs up emoji

@javiereguiluz
Copy link
MemberAuthor

Given that it's the DSN, I've updated the design as follows:

transport-sent

transport-queued

HeahDude, 94noni, OskarStark, and artyuum reacted with heart emoji

@ro0NL
Copy link
Contributor

what about showing multiple emails inbox-like? eg. a list of subject and date.

@stof
Copy link
Member

@ro0NL I doubt you will have web requests sending lots of emails (such case must be handled asynchronously). So it is better to optimize the experience for a few emails than for the case of a big list IMO.

@ro0NL
Copy link
Contributor

ro0NL commentedSep 21, 2022•
edited
Loading

im not sure how not seeing the subject improves the experience ...

@stof
Copy link
Member

Well, if you want to display the subject instead of just#1 and#2, it requires moving away from horizontal tabs then (as the subject won't fit in them), which means adding much more space for this email switcher.

@javiereguiluz
Copy link
MemberAuthor

I liked@ro0NL proposal, so I gave it a shot ... and I think it works better. It now shows a clickable list of messages to follow the familiar behavior of email clients:

mailer-email-list

We also protect the design against too long lists:

mailer-list-long

artyuum, tarlepp, quentint, 94noni, DanielBadura, Crovitche-1623, Chris53897, martijn80, and cur53se reacted with hooray emoji

@javiereguiluz
Copy link
MemberAuthor

@stof I thought about what you said and I think you were right. That's why I've changed my mind and introduced some buttons in the table of emails to make it accessible.

This is how it looks when using a browser with accessibility capabilities. In regular browsers, the buttons are completely hidden:

table-accessible

So, I think this feature is now ready and complete. Thanks.

@fabpot
Copy link
Member

Thank you@javiereguiluz.

@fabpotfabpot merged commitcc4003b intosymfony:6.2Oct 1, 2022
@javiereguiluzjaviereguiluz deleted the mailer_panel branchOctober 1, 2022 14:58
@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

+1 more reviewer

@94noni94noni94noni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

6 participants

@javiereguiluz@stof@ro0NL@fabpot@94noni@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp