NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[DomCrawler] impossible to test a value out of the options in ChoiceFormField#47642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

jorissae wants to merge1 commit intosymfony:7.4

base:7.4

Choose a base branch

fromjorissae:impossible-to-test-a-value-out-of-the-options

Open

[DomCrawler] impossible to test a value out of the options in ChoiceFormField#47642

jorissae wants to merge1 commit intosymfony:7.4fromjorissae:impossible-to-test-a-value-out-of-the-options

Conversation

Copy link

Contributor

jorissae commentedSep 21, 2022•
edited
Loading

Q	A
Branch?	6.2
Bug fix?	No
New feature?	No
Deprecations?	No
Tickets	>
License	MIT
Doc PR

I couldn't test a value outside of the ChoiceForm field option nodes.
For example, even if my combobox does not offer the empty field, I want to test my NotBlank validator.

<?php$form =$crawler->selectButton('ea[newForm][btn]')->form();$client->submit($form, ['Item[vat]' =>'']);

in Symfony\Component\BrowserKit\AbstractBrowser::submit ($client->submit())

publicfunctionsubmit(Form$form,array$values = [],array$serverParameters = []):Crawler{$form->setValues($values);return$this->request($form->getMethod(),$form->getUri(),$form->getPhpValues(),$form->getPhpFiles(),$serverParameters);}

InvalidArgumentException: Input "Item[vat]" cannot take "" as a value (possible values: "0", "700", "1900").

maybe there is another solution ? (like add arguments bool $throw = true to setValues or another ...)

Thanks

impossible to test a value out of the options in ChoiceFormField

131cee1

carsonbot added the Status: Needs Review label

Sep 21, 2022

carsonbot added this to the6.2 milestone

Sep 21, 2022

Copy link

carsonbot commentedSep 21, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

xabbuh added Feature DomCrawler labels

Sep 21, 2022

carsonbot changed the title~~impossible to test a value out of the options in ChoiceFormField~~[DomCrawler] impossible to test a value out of the options in ChoiceFormField

Sep 21, 2022

Copy link

carsonbot commentedOct 29, 2022

Hey!

I think@localheinz has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

nicolas-grekas modified the milestones:6.2,6.3

Nov 5, 2022

nicolas-grekas modified the milestones:6.3,6.4

May 23, 2023

nicolas-grekas modified the milestones:6.4,7.1

Nov 15, 2023

Copy link

Contributor

norkunas commentedDec 7, 2023

Does nobody test autocomplete fields? 😅
Would be great addition.

norkunas mentioned this pull request

Dec 13, 2023

[Autocomplete] Testing an autocompletesymfony/ux#1334

Open

Copy link

Member

yceruto commentedDec 13, 2023

If the option doesn't exist is because it's added dynamically via Javascript, so you'll need to simulate that behavior by usingChoiceFormField::addChoice($node) method before submit.

I don't think we should remove the validation check.