NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DependencyInjection] [Bugfix] EnvPlaceholderParameterBag::get() can't return UnitEnum#47634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

php-rock wants to merge4 commits intosymfony:6.2fromphp-rock:bugfix/AddUnitEnum

Closed

[DependencyInjection] [Bugfix] EnvPlaceholderParameterBag::get() can't return UnitEnum#47634

php-rock wants to merge4 commits intosymfony:6.2fromphp-rock:bugfix/AddUnitEnum

Conversation

Copy link

php-rock commentedSep 20, 2022•
edited
Loading

Q	A
Branch?	6.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

This PR allows to get enums from container in the next situation:

parameters:    app.someEnum.yes !php/const \App\Context\SomeEnum::YES

Currently, we'll have an error:

[critical] Uncaught Error: Symfony\Component\DependencyInjection\ParameterBag\EnvPlaceholderParameterBag::get(): Return value must be of type array|string|int|float|bool|null, \App\Context\SomeEnum returned

This bugfix fixes this error.

Why do we need this fix?
To make the results of two dependent methods consistent.

EnvPlaceholderParameterBag::get() callParameterBag::get() here:

symfony/src/Symfony/Component/DependencyInjection/ParameterBag/EnvPlaceholderParameterBag.php

Line 58 inb7ce8f2

returnparent::get($name);

This PR makes it consistent and adding UnitEnum toEnvPlaceholderParameterBag::get() result.

jack.shpartko added3 commits

September 20, 2022 22:15

Bugfix: add \UnitEnum as a result of get() method

40e6009

Add test: add \UnitEnum as a result of get() method

4bf87cd

Add test: add \UnitEnum as a result of get() method

5d20a22

carsonbot added Status: Needs Review Bug labels

Sep 20, 2022

carsonbot added this to the6.2 milestone

Sep 20, 2022

Copy link

carsonbot commentedSep 20, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Fix message format

249ec1f

php-rock changed the title~~EnvPlaceholderParameterBag::get() can't return UnitEnum~~Bugfix: EnvPlaceholderParameterBag::get() can't return UnitEnum

Sep 20, 2022

php-rock changed the title~~Bugfix: EnvPlaceholderParameterBag::get() can't return UnitEnum~~[DependencyInjection] [Bugfix] EnvPlaceholderParameterBag::get() can't return UnitEnum

Sep 20, 2022