NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Allow getting discriminated type by class name#47621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.4frommotleyhu:serializer-allow-get-type-by-class-name

Oct 11, 2022

Merged

[Serializer] Allow getting discriminated type by class name#47621

nicolas-grekas merged 1 commit intosymfony:4.4frommotleyhu:serializer-allow-get-type-by-class-name

Oct 11, 2022

+2 −1

Conversation

Copy link

Contributor

TamasSzigeti commentedSep 19, 2022

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

Fixing:ClassDiscriminatorMapping::getMappedObjectType allows string input but hasn't worked with class name

[Serializer] Allow getting discriminated type by class name

84041a1

TamasSzigeti requested a review fromdunglas as acode owner

September 19, 2022 08:41

carsonbot added Status: Needs Review Bug Serializer labels

Sep 19, 2022

carsonbot added this to the4.4 milestone

Sep 19, 2022

Copy link

carsonbot commentedSep 19, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

carsonbot commentedSep 19, 2022

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot