Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Separate WorkerRunningEvent into WorkerBusyEvent and WorkerIdleEvent#47573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Jeroeny wants to merge1 commit intosymfony:7.4Choose a base branch fromJeroeny:worker
base:7.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+105 −45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
A common usecase for WorkerRunning listeners seems to be that they perform logic based on
$event->isWorkerIdle()
. E.g. sometimes services only need to reset if a message has been processed. Or non-critical logic needs to happen when the worker is not busy, to keep the processing performant (like keeping a cache warm or sending buffered metrics).Right now each of those listeners need to be called, upon which they check themselves if the worker is busy. To increase performance, the WorkerRunning event can be split into
WorkerBusyEvent
andWorkerIdleEvent
. This way listeners can be explicit about when they want to act. Since these events are emitted in a loop, this could make a difference.There doesn't seem to be a way to deprecate an event, so I think the
WorkerRunning
event remains.Though
WorkerRunning::isWorkerIdle()
could be deprecated to stimulate the usage of the new events.