Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Separate WorkerRunningEvent into WorkerBusyEvent and WorkerIdleEvent#47573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Jeroeny wants to merge1 commit intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromJeroeny:worker

Conversation

Jeroeny
Copy link
Contributor

@JeroenyJeroeny commentedSep 14, 2022
edited
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?maybe
LicenseMIT

A common usecase for WorkerRunning listeners seems to be that they perform logic based on$event->isWorkerIdle(). E.g. sometimes services only need to reset if a message has been processed. Or non-critical logic needs to happen when the worker is not busy, to keep the processing performant (like keeping a cache warm or sending buffered metrics).
Right now each of those listeners need to be called, upon which they check themselves if the worker is busy. To increase performance, the WorkerRunning event can be split intoWorkerBusyEvent andWorkerIdleEvent. This way listeners can be explicit about when they want to act. Since these events are emitted in a loop, this could make a difference.

There doesn't seem to be a way to deprecate an event, so I think theWorkerRunning event remains.
ThoughWorkerRunning::isWorkerIdle() could be deprecated to stimulate the usage of the new events.

@xabbuhxabbuh modified the milestones:7.1,7.2May 15, 2024
@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jderussejderussejderusse left review comments

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

6 participants
@Jeroeny@jderusse@fabpot@nicolas-grekas@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp