Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Allow colon (:) in cache key#47561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lyrixx wants to merge1 commit intosymfony:6.2fromlyrixx:cache-colon

Conversation

lyrixx
Copy link
Member

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#45599
LicenseMIT
Doc PR

@lyrixx
Copy link
MemberAuthor

I guess I must edit a CHANGELOG.md but I don't understand how it work.

Is itsrc/Symfony/Contracts/CHANGELOG.md? what version should I pick?

@nicolas-grekas
Copy link
Member

Tests fail, we need to override some methods from the base class.

@nicolas-grekas
Copy link
Member

Should we do this only when the contracts are used? Aka when using the PSR-6 interface, still throw?

@upyx
Copy link
Contributor

I've described why it would be better to still forbid semicolons in cache keys in the#45599.

@nicolas-grekas
Copy link
Member

I'm closing here because this was a poc and it showed we need more discussion - also because the implementation is likely not the one we'll want.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

[Cache] Allow colon in key key (with redis at least)
4 participants
@lyrixx@nicolas-grekas@upyx@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp