Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Ldap] Do not run ldap_set_option on failed connection#47547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tatankat
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

ldap_set_option should only be called on null (first time setOption is run) or on an LDAP\Connection instance. When ldap_connect fails, it returns a boolean. ldap_set_option fails on this, which results in an early TypeError instead of the LdapException with the real issue: 'Could not connect to Ldap server'. So, the result of ldap_connect should be checked earlier.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot added this to the6.2 milestoneSep 11, 2022
@tatankattatankat changed the base branch from6.2 to4.4September 11, 2022 23:31
@nicolas-grekasnicolas-grekas modified the milestones:6.2,4.4Sep 12, 2022
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, LGTM, I just have minor CS comments.

@nicolas-grekas
Copy link
Member

Thank you@tatankat.

@nicolas-grekasnicolas-grekas merged commit99e9733 intosymfony:4.4Sep 28, 2022
This was referencedSep 30, 2022
tatankat added a commit to tatankat/joomla-cms that referenced this pull requestSep 30, 2022
@fabpotfabpot mentioned this pull requestSep 30, 2022
laoneo pushed a commit to joomla/joomla-cms that referenced this pull requestJan 30, 2023
* Restore broken ldap debugging functionality* Fix composer.lock* Remove unnecessary change* More recent symfony/ldap to includesymfony/symfony#47547* fix hash in composer.lock* Update composer.lock---------
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@tatankat@carsonbot@nicolas-grekas@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp