Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form][PropertyAccess] Allow optional property accesses#47511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fsoedjede
Copy link
Contributor

@fsoedjedefsoedjede commentedSep 7, 2022•
edited
Loading

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?yes
TicketsFix#34483
LicenseMIT
Doc PRsymfony/symfony-docs#17288

This PR is basically a copy of#34497 with some minor changes.

I needed it and I have some time now to help advance in implementing it.

TODO

  • Add nullsafe operator usage
  • Update unit test
  • Update documentation

Regards

Jibbarth reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[PropertyAccess][Form] Allow optional property accesses[Form][PropertyAccess] Allow optional property accessesSep 7, 2022
@fsoedjedefsoedjedeforce-pushed the34483-property-access-add-nullsafe-operator branch from698ca57 to1a58136CompareSeptember 7, 2022 17:53
@carsonbot
Copy link

Hey!

I think@b1rdex has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fsoedjedefsoedjede requested review fromb1rdex and removed request forxabbuh andycerutoSeptember 22, 2022 19:22
@fsoedjede
Copy link
ContributorAuthor

@ogizanagi would you mind check this PR please

Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for taking over this feature request@fsoedjede

@fabpot
Copy link
Member

Thank you@fsoedjede.

fsoedjede reacted with rocket emoji

@fabpotfabpot merged commitd9462d9 intosymfony:6.2Oct 1, 2022
@fsoedjedefsoedjede deleted the 34483-property-access-add-nullsafe-operator branchOctober 1, 2022 17:38
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestOct 4, 2022
… (fsoedjede)This PR was merged into the 6.2 branch.Discussion----------[PropertyAccess] Document nullsafe operator usage<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `6.x` for features of unreleased versions).-->Doc PR forsymfony/symfony#47511Commits-------6a5d2ee [PropertyAccess] Document nullsafe operator usage
@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@b1rdexb1rdexAwaiting requested review from b1rdex

1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[PropertyAccess] Add nullsafe operator support

5 participants

@fsoedjede@carsonbot@fabpot@b1rdex@ogizanagi
[8]ページ先頭
©2009-2025 Movatter.jp