Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Make the Routercache_dir configurable#47496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mpdude commentedSep 8, 2022
fabbot.io failure is not due to this PR |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks sensible to me
chalasr commentedSep 23, 2022
(Rebased needed) |
mpdude commentedSep 26, 2022
Merge conflicts resolved. |
fabpot commentedOct 1, 2022
@mpdude Can you rebase to get rid of the merge commit? |
e7cace1 to5804c50Comparempdude commentedOct 1, 2022
@fabpot done |
mpdude commentedOct 1, 2022
Out of curiosity, (why) would a merge commit matter if you do a squash merge anyway? |
5804c50 todd65d30Comparefabpot commentedOct 1, 2022
The script we are using to do the merge doesn't always work well in such situations. |
fabpot commentedOct 1, 2022
Thank you@mpdude. |
…ude)This PR was squashed before being merged into the 6.2 branch.Discussion----------Document the `framework.router.cache_dir` settingThis documents a new configuration setting suggested insymfony/symfony#47496.Commits-------24b9b1d Document the `framework.router.cache_dir` setting
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a new
framework.router.cache_dirconfiguration setting. It will default tokernel.cache_diras previously, but makes it possible to easily re-configure the Router's cache directory.My intended use case is to set it to
~(null) for thetestenvironment because I need to modify or otherwise dynamically load routes during tests. Another use case I see for it is to have tenant-specific route configurations and caches in multi-tenancy applications.