Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Make the Routercache_dir configurable#47496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2frommpdude:router-cache-dir-config
Oct 1, 2022

Conversation

@mpdude
Copy link
Contributor

@mpdudempdude commentedSep 6, 2022
edited
Loading

QA
Branch?6.2 for features
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#17253

This PR adds a newframework.router.cache_dir configuration setting. It will default tokernel.cache_dir as previously, but makes it possible to easily re-configure the Router's cache directory.

My intended use case is to set it to~ (null) for thetest environment because I need to modify or otherwise dynamically load routes during tests. Another use case I see for it is to have tenant-specific route configurations and caches in multi-tenancy applications.

Guikingone reacted with heart emoji
@mpdude
Copy link
ContributorAuthor

fabbot.io failure is not due to this PR

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks sensible to me

@chalasr
Copy link
Member

(Rebased needed)

@mpdude
Copy link
ContributorAuthor

Merge conflicts resolved.

@fabpot
Copy link
Member

@mpdude Can you rebase to get rid of the merge commit?

@mpdudempdudeforce-pushed therouter-cache-dir-config branch frome7cace1 to5804c50CompareOctober 1, 2022 13:59
@mpdude
Copy link
ContributorAuthor

@fabpot done

@mpdude
Copy link
ContributorAuthor

Out of curiosity, (why) would a merge commit matter if you do a squash merge anyway?

@fabpotfabpotforce-pushed therouter-cache-dir-config branch from5804c50 todd65d30CompareOctober 1, 2022 14:05
@fabpot
Copy link
Member

The script we are using to do the merge doesn't always work well in such situations.

mpdude reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@mpdude.

@fabpotfabpot merged commit1b3b14c intosymfony:6.2Oct 1, 2022
@mpdudempdude deleted the router-cache-dir-config branchOctober 1, 2022 14:08
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestOct 1, 2022
…ude)This PR was squashed before being merged into the 6.2 branch.Discussion----------Document the `framework.router.cache_dir` settingThis documents a new configuration setting suggested insymfony/symfony#47496.Commits-------24b9b1d Document the `framework.router.cache_dir` setting
@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@mpdude@chalasr@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp