Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Make Logger implement DebugLoggerInterface#47483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromMatTheCat:debug_logger
Oct 20, 2022

Conversation

@MatTheCat
Copy link
Contributor

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

When starting a new project from a skeleton I was surprised not to see any log in the profiler and error pages. Turns out this depends of the logger implementingDebugLoggerInterface but AFAIK this only happen in Monolog’s bridge.

Given the API makes it weird to implement it in userland (see#47396) would it make sense to provide one by default?

@carsonbotcarsonbot added Status: Needs Review Feature HttpKernel RFCRFC = Request For Comments (proposals about features that you want to be discussed) labelsSep 4, 2022
@carsonbotcarsonbot added this to the6.2 milestoneSep 4, 2022
@carsonbotcarsonbot changed the title[RFC][HttpKernel] Make Logger implement DebugLoggerInterface[HttpKernel] Make Logger implement DebugLoggerInterfaceSep 4, 2022
@MatTheCatMatTheCatforce-pushed thedebug_logger branch 2 times, most recently fromaaf7197 to438b512CompareSeptember 14, 2022 15:11
@MatTheCat
Copy link
ContributorAuthor

MatTheCat commentedSep 14, 2022•
edited
Loading

Thanks for your feedback 🙏

I updated the PR accordingly.

@MatTheCatMatTheCatforce-pushed thedebug_logger branch 3 times, most recently fromd59e2fb to9a9cc67CompareSeptember 21, 2022 16:04
MatTheCat added a commit to MatTheCat/symfony that referenced this pull requestOct 17, 2022
MatTheCat added a commit to MatTheCat/symfony that referenced this pull requestOct 17, 2022
MatTheCat added a commit to MatTheCat/symfony that referenced this pull requestOct 17, 2022
MatTheCat added a commit to MatTheCat/symfony that referenced this pull requestOct 17, 2022
MatTheCat added a commit to MatTheCat/symfony that referenced this pull requestOct 17, 2022
@nicolas-grekasnicolas-grekas added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelOct 19, 2022
@fabpot
Copy link
Member

Thank you@MatTheCat.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxlyrixx left review comments

@derrabusderrabusderrabus left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

FeatureHttpKernelRFCRFC = Request For Comments (proposals about features that you want to be discussed)❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

7 participants

@MatTheCat@fabpot@nicolas-grekas@lyrixx@ro0NL@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp