Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Display aliases indebug:container command#47427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jlslew wants to merge1 commit intosymfony:7.1fromjlslew:feature/39381

Conversation

@jlslew
Copy link

@jlslewjlslew commentedAug 30, 2022
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#39381
LicenseMIT
Doc PR-

Runningbin/console debug:container cache.app --show-arguments --with-aliases --format FORMAT on a symfony/skeleton:6.2 project

Alias(Symfony\Component\Cache\Marshaller\DefaultMarshaller, Service(cache.default_marshaller))
<argumentalias="Symfony\Component\Cache\Marshaller\DefaultMarshaller"type="service"id="cache.default_marshaller"/>
{"alias":"Symfony\\Component\\Cache\\Marshaller\\DefaultMarshaller","type":"service","id":"cache.default_marshaller"}
- Argument:`cache.default_marshaller`- Alias: Symfony\Component\Cache\Marshaller\DefaultMarshaller

EDIT: It might break BC because methods' signature has been changed (Added an argument with a default value)

Koc reacted with thumbs up emoji
@carsonbotcarsonbot added this to the6.2 milestoneAug 30, 2022
@jlslewjlslew changed the titleFeature/39381 Display aliases in debug:container command[Console] Feature/39381 Display aliases in debug:container commandAug 30, 2022
@OskarStarkOskarStark changed the title[Console] Feature/39381 Display aliases in debug:container command[Console] Display aliases indebug:container commandSep 8, 2022
@nicolas-grekasnicolas-grekas modified the milestones:6.2,6.3Nov 5, 2022
@carsonbotcarsonbot changed the title[Console] Display aliases indebug:container commandDisplay aliases indebug:container commandFeb 8, 2023
@94noni
Copy link
Contributor

nice addition it will help in dev a lot

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you implement it for the Markdown descriptor as well?

@jlslew
Copy link
Author

Can you implement it for the Markdown descriptor as well?

Will do

@carsonbotcarsonbot changed the titleDisplay aliases indebug:container command[FrameworkBundle] Display aliases indebug:container commandSep 14, 2023
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I rebased the PR but there are some failures to fix.
@jlslew could you please have a look?

'id' => (string)$value,
];
}
}catch (\Throwable$throwable) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can this be more specific? what kind of exceptions can we expect here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@jlslew Any feedback?

@nicolas-grekasnicolas-grekas modified the milestones:6.4,7.1Nov 15, 2023
* Add`DomCrawlerAssertionsTrait::assertAnySelectorTextContains(string $selector, string $text)`
* Add`DomCrawlerAssertionsTrait::assertAnySelectorTextSame(string $selector, string $text)`
* Add`DomCrawlerAssertionsTrait::assertAnySelectorTextNotContains(string $selector, string $text)`
* Display aliases in debug:container command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
* Display aliases in debug:container command
* Display aliases in`debug:container` command

@nicolas-grekas
Copy link
Member

@jlslew up to resume this PR?
Anyone else would like to take over?

@94noni
Copy link
Contributor

if no news for@jlslew I would be glad to take over his initial work, as this PR is mostly finished and can add great value imho

@fabpot
Copy link
Member

@94noni Please, can you take over this PR?

@jlslew
Copy link
Author

@94noni you can take over the PR, thanks.

@94noni
Copy link
Contributor

PR landed here#54459

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

+1 more reviewer

@94noni94noni94noni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

Display aliases in debug:container command

5 participants

@jlslew@94noni@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp