The behavior of->snake() method from String component has changed in 6.1.4, now, usingu('SYMFONY')->snake() returns_ymfony instead ofsymfony (#47185).

After, some investigations, it seams the->camel() behavior is not exactly the expected one:u('SYMFONY')->camel() returnsYMFONY instead ofSYMFONY.

This PR give theses behaviors:

CamelCase:
- '' => ''
- x_y => xY
- xu_yo => xuYo
- symfony_is_great => symfonyIsGreat
- symfony_5_is_great => symfony5IsGreat
- Symfony is great => symfonyIsGreat
- Symfony is a great framework => symfonyIsAGreatFramework
- *Symfony* is GREAT!! => symfonyIsGREAT
- SYMFONY => SYMFONY
SnakeCase:
- '' => ''
- x_y => x_y
- X_Y => x_y
- xu_yo => xu_yo
- symfonyIsGreat => symfony_is_great
- symfony5IsGreat => symfony5_is_great
- symfony5isGreat => symfony5is_great
- Symfony is great => symfony_is_great
- symfonyIsAGreatFramework => symfony_is_a_great_framework
- symfonyIsGREAT => symfony_is_great
- symfonyIsREALLYGreat => symfony_is_really_great
- SYMFONY => symfony

carsonbot added Status: Needs Review Bug String labels

Aug 29, 2022

carsonbot added this to the6.2 milestone

Aug 29, 2022

mpiot force-pushed thestring-camel-snake branch 3 times, most recently from5fac902 tof9129e6Compare

August 29, 2022 10:52

OskarStark approved these changes

Aug 29, 2022

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 29, 2022

Copy link

Member

xabbuh commentedAug 31, 2022

This affects Symfony 5.4 too, doesn't it?

Copy link

ContributorAuthor

mpiot commentedAug 31, 2022

@xabbuh oh yes#47185 has been merged in 5.4 branch.

xabbuh modified the milestones:6.2,5.4

Aug 31, 2022

fabpot approved these changes

Sep 1, 2022

View reviewed changes

[String] CamelCase/SnakeCase on uppercase word

c3cae1f

fabpot changed the base branch from6.2 to5.4

September 1, 2022 01:52

fabpot requested review fromchalasr,dunglas,jderusse,lyrixx,wouterj,xabbuh andyceruto ascode owners

September 1, 2022 01:52

carsonbot added Status: Needs Review and removed Status: Reviewed labels

Sep 1, 2022

Copy link

Member

fabpot commentedSep 1, 2022

Thank you@mpiot.

fabpot merged commitc61dfca intosymfony:5.4

Sep 1, 2022

mpiot deleted the string-camel-snake branch

September 1, 2022 04:47

fabpot mentioned this pull request

Sep 30, 2022

Release v5.4.13#47738

Merged

This was referencedSep 30, 2022

Release v6.0.13#47739

Merged

Release v6.1.5#47740

Merged

nicolas-grekas mentioned this pull request

Jul 1, 2024

[String] Revert "Fixed u()->snake(), b()->snake() and s()->snake() methods"#57616

Merged

fabpot added a commit that referenced this pull request

Jul 1, 2024

bug#57616[String] Revert "Fixed u()->snake(), b()->snake() and s()-…

e3625f2

…>snake() methods" (nicolas-grekas)This PR was squashed before being merged into the 5.4 branch.Discussion----------[String] Revert "Fixed u()->snake(), b()->snake() and s()->snake() methods"| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#57612| License       | MITThis PR reverts#57497 for BC reasons, but keeps the test cases we added in the process. Those test cases allowed to spot a real issue where the ascii and unicode implementations didn't agree on the resulting camel case for `SYMFONY IS GREAT`. Both implementations now result in `SYMFONYISGREAT` (likely introduced in#47423).Commits-------6397c38 [String] Revert "Fixed u()->snake(), b()->snake() and s()->snake() methods"