NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

Replace get_class() calls by ::class#47401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.2fromdeguif:get_class_to_class_keyword-cs-rule

Sep 1, 2022

Merged

Replace get_class() calls by ::class#47401

fabpot merged 1 commit intosymfony:6.2fromdeguif:get_class_to_class_keyword-cs-rule

Sep 1, 2022

Conversation

Copy link

Contributor

deguif commentedAug 26, 2022

Q	A
Branch?	6.2
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

Replaceget_class() by::class

deguif requested review fromxabbuh,wouterj,chalasr,dunglas,yceruto andOskarStark ascode owners

August 26, 2022 15:00

carsonbot added the Status: Needs Review label

Aug 26, 2022

carsonbot added this to the6.2 milestone

Aug 26, 2022

fabpot requested changes

Aug 26, 2022

View reviewed changes

src/Symfony/Bridge/PhpUnit/CoverageListener.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Aug 26, 2022

Copy link

Member

stof commentedAug 26, 2022

I'm really not convinced that$object::class is more readable thanget_class($object). I would be in favor of keeping the usage ofget_class

deguif force-pushed theget_class_to_class_keyword-cs-rule branch from7bf01b2 to32eded8Compare

August 26, 2022 15:16

Copy link

Member

nicolas-grekas commentedAug 26, 2022•
edited
Loading

I like the change personally. It gives a consistent syntax to get the class of something. Once used to it, we won't want to get back :)

derrabus approved these changes

Aug 26, 2022

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Aug 26, 2022

chalasr approved these changes

Aug 30, 2022

View reviewed changes

artyuum approved these changes

Aug 31, 2022

View reviewed changes

Replace get_class() calls by ::class

675601b

fabpot force-pushed theget_class_to_class_keyword-cs-rule branch from32eded8 to675601bCompare

September 1, 2022 02:03

Copy link

Member

fabpot commentedSep 1, 2022

Thank you@deguif.

fabpot merged commit0be39ad intosymfony:6.2

Sep 1, 2022

deguif deleted the get_class_to_class_keyword-cs-rule branch

September 1, 2022 03:51

PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request

Sep 6, 2023

minorsymfony#47401Replace get_class() calls by ::class (deguif)

41773f1

This PR was squashed before being merged into the 6.2 branch.Discussion----------Replace get_class() calls by ::class| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |Replace `get_class()` by `::class`Commits-------675601b Replace get_class() calls by ::class

This was referencedMay 29, 2025

Replaceget_class() calls by::class#60581

Merged

Replaceget_class() calls by::classsymfony/symfony-docs#21016

Merged

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request

May 29, 2025

minor#21016Replaceget_class()calls by::class(alamirault)

3d83f8d

This PR was merged into the 6.4 branch.Discussion----------Replace `get_class()` calls by `::class`This change was made in symfony codebase in 2022symfony/symfony#47401.I think we can use same rule in our examplesCommits-------65599c4 Replace get_class() calls by ::class

nicolas-grekas added a commit that referenced this pull request

May 30, 2025

minor#60581Replaceget_class()calls by::class(alamirault)

d92477a

This PR was merged into the 7.4 branch.Discussion----------Replace `get_class()` calls by `::class`| Q             | A| ------------- | ---| Branch?       | 7.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License       | MITReplace `get_class()` by `::class`It was already done in past in#47401Commits-------e0a602b Replace get_class() calls by ::class