Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Add Chatwork Notifier Bridge#47373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromIppey:add-chatwork-notifier
Aug 26, 2022

Conversation

@Ippey
Copy link
Contributor

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

Add Chatwork Notifier Bridge.

Chatwork is one of the popular chat tools in Japan.
This bridge allows sending messages to Chatwork viaChatwork API.

OskarStark reacted with thumbs up emoji
try {
$statusCode = $response->getStatusCode();
} catch (TransportExceptionInterface $e) {
throw new TransportException('Could not reach the remote Discord server.', $response, 0, $e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
thrownewTransportException('Could not reach the remoteDiscord server.',$response,0,$e);
thrownewTransportException('Could not reach the remoteChatwork server.',$response,0,$e);

$originalContent = $message->getSubject();
$result = $response->toArray(false);
$errors = $result['errors'];
throw new TransportException(sprintf('Unable to post the Chatwork message: "%s" (%d: "%s").', $originalContent, $statusCode, implode(', ', $errors)), $response);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
thrownewTransportException(sprintf('Unable to post the Chatwork message: "%s" (%d:"%s").',$originalContent,$statusCode,implode(',',$errors)),$response);
thrownewTransportException(sprintf('Unable to post the Chatwork message: "%s" (%d:%s).',$originalContent,$statusCode,implode(',',$errors)),$response);

If you received an error from fabbot here, that's a false positive.

@@ -0,0 +1,19 @@
Chatwork Notifier
===============
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
===============
=================

@Ippey
Copy link
ContributorAuthor

@fabpot Thank you, I applied those suggestions.

@fabpot
Copy link
Member

@Ippey Can you open a PR on symfony/recipes (like thisone for instance).

@fabpotfabpotforce-pushed theadd-chatwork-notifier branch from571eda6 to6dcab51CompareAugust 26, 2022 07:51
@fabpot
Copy link
Member

Thank you@Ippey.

Ippey reacted with heart emoji

@Ippey
Copy link
ContributorAuthor

@fabpot Created PR.

symfony/recipes#1121

@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Ippey@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp