Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Handle INI arrays#47367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromMatTheCat:ticket_47357
Aug 26, 2022

Conversation

@MatTheCat
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#47357
LicenseMIT
Doc PRN/A

@fabpot
Copy link
Member

Looks like a new feature to me.

@lpd-au
Copy link

Looks like a new feature to me.

In what way? It's fixing a regression in 3.2.0.

@fabpot
Copy link
Member

It's not supported today, so that's a new feature.

lpd-au reacted with thumbs down emoji

@fabpotfabpot modified the milestones:4.4,6.2Aug 23, 2022
@lpd-au
Copy link

Strange perspective, not throwing a TypeError on valid input is a feature?

@fabpot
Copy link
Member

Strange perspective, not throwing a TypeError on valid input is a feature?

But then, everything is a bug fix.
Anyway, we favor stability over everything else in our maintained branches, so we're very strict in what we consider a bug.

@lpd-au
Copy link

But then, everything is a bug fix.
Anyway, we favor stability over everything else in our maintained branches, so we're very strict in what we consider a bug.

I don't understand the point you're trying to make, there's a great scope between fixing a thrownError and adding new functionality. Nonetheless, this should have little to no backwards compatibility impact; if your code was working beforehand, it'll still work now.

@MatTheCat
Copy link
ContributorAuthor

MatTheCat commentedAug 23, 2022
edited
Loading

It's not supported today, so that's a new feature.

But it was at some point 🤔 I don't know how Symfony handles regressions though (Wikipedia says regressions are bugs).

@fabpot
Copy link
Member

Symfony 3.2 EOLed was 5 years ago. Nobody reported this since then. So, that's a new feature.
As I said, we have a very strict definition of what is considered a new feature vs a bug.

MatTheCat reacted with thumbs up emoji

@fabpotfabpot changed the base branch from4.4 to6.2August 26, 2022 08:55
@fabpot
Copy link
Member

Thank you@MatTheCat.

@lpd-au
Copy link

lpd-au commentedAug 26, 2022
edited
Loading

Symfony 3.2 EOLed was 5 years ago. Nobody reported this since then. So, that's a new feature. As I said, we have a very strict definition of what is considered a new feature vs a bug.

For PHP 7.x, this only became a TypeError in 4.4, before that it was only a PHP warning. Btw, this "nobody" reported it while trying to upgrade a legacy app.

@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasAwaiting requested review from dunglas

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

IniFileLoader throws when parsing arrays

4 participants

@MatTheCat@fabpot@lpd-au@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp