Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix broken request stack state if throwable is thrown.#47358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromWarxcell:fix_stale_request_stack
Aug 23, 2022

Conversation

@Warxcell
Copy link
Contributor

@WarxcellWarxcell commentedAug 22, 2022•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

When using long-running server (like roadrunner) if Throwable is thrown - requestStack is never pop out and it stays in broken state and next requests receive previous request object.

@carsonbotcarsonbot added this to the6.2 milestoneAug 22, 2022
@WarxcellWarxcellforce-pushed thefix_stale_request_stack branch from39674e0 tof55c39dCompareAugust 22, 2022 15:01
@WarxcellWarxcell changed the titleFix stale request stackFix broken request stack state if throwable is thrown.Aug 22, 2022
@WarxcellWarxcell changed the base branch from6.2 to4.4August 22, 2022 15:01
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me. Can you add some tests?

Warxcell reacted with thumbs up emoji
@Warxcell
Copy link
ContributorAuthor

Added tests, tho I'm not quite sure what's the best way to throw Throwable.

@WarxcellWarxcellforce-pushed thefix_stale_request_stack branch fromb1a7414 toeb4b5aaCompareAugust 22, 2022 15:19
@WarxcellWarxcellforce-pushed thefix_stale_request_stack branch 2 times, most recently from4a3802a to9512ce0CompareAugust 22, 2022 15:21
@stof
Copy link
Member

Instead of a test requiring a file with a syntax error, it would be simpler to make a function trigger aError here.

@WarxcellWarxcellforce-pushed thefix_stale_request_stack branch from9512ce0 toe5c4190CompareAugust 22, 2022 15:29
@Warxcell
Copy link
ContributorAuthor

Error

Ah yes, totally forgot about it. Thanks!

@WarxcellWarxcellforce-pushed thefix_stale_request_stack branch frome5c4190 toe35d6baCompareAugust 22, 2022 16:35
@fabpot
Copy link
Member

Thank you@Warxcell.

Warxcell reacted with heart emoji

@fabpotfabpot merged commit17a8daf intosymfony:4.4Aug 23, 2022
This was referencedAug 26, 2022
@fabpotfabpot mentioned this pull requestSep 30, 2022
nicolas-grekas added a commit that referenced this pull requestOct 18, 2022
… exception (krzyc)This PR was squashed before being merged into the 4.4 branch.Discussion----------[HttpKernel] Fix empty request stack when terminating with exception| Q             | A| ------------- | ---| Branch?       | 4.4, 5.4, 6.0, 6.1, 6.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#47577| License       | MIT| Doc PR        |After#47358 the RequestStack is empty when request terminates with exception, which prevents SecurityDataCollector to generate logout URL and generates fatal error.Commits-------e4d6e7b [HttpKernel] Fix empty request stack when terminating with exception
symfony-splitter pushed a commit to symfony/http-kernel that referenced this pull requestOct 18, 2022
… exception (krzyc)This PR was squashed before being merged into the 4.4 branch.Discussion----------[HttpKernel] Fix empty request stack when terminating with exception| Q             | A| ------------- | ---| Branch?       | 4.4, 5.4, 6.0, 6.1, 6.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Fix #47577| License       | MIT| Doc PR        |Aftersymfony/symfony#47358 the RequestStack is empty when request terminates with exception, which prevents SecurityDataCollector to generate logout URL and generates fatal error.Commits-------e4d6e7b4ba [HttpKernel] Fix empty request stack when terminating with exception
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr left review comments

@fabpotfabpotfabpot approved these changes

@dunglasdunglasAwaiting requested review from dunglas

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

5 participants

@Warxcell@stof@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp