Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change incorrect message, when the sender in the global envelope or the from header of asEmailMessage() is not defined.#47342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fredericlesueurs
Copy link
Contributor

See issue:#47313

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix 47313
LicenseMIT
Doc PRno

Correction of an error message containing a syntax structure error.
See issue:#47313

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fredericlesueursfredericlesueurs changed the titleFixed incorrect message, when the sender in the global envelope or the from header of asEmailMessage() is not defined.Change incorrect message, when the sender in the global envelope or the from header of asEmailMessage() is not defined.Aug 19, 2022
@nicolas-grekasnicolas-grekas modified the milestones:6.2,6.3Nov 5, 2022
@nicolas-grekasnicolas-grekas modified the milestones:6.3,6.4May 23, 2023
…he from header of asEmailMessage() is not defined.
@fabpotfabpot changed the base branch from6.4 to5.4October 1, 2023 07:26
@fabpotfabpotforce-pushed thefeature/fix-incorect-message-error-in-email-channel branch from3e401cd to5d9d6b7CompareOctober 1, 2023 07:26
@fabpot
Copy link
Member

Thank you@fredericlesueurs.

fredericlesueurs reacted with heart emoji

@fabpotfabpot merged commit2e11577 intosymfony:5.4Oct 1, 2023
@fabpotfabpot mentioned this pull requestOct 21, 2023
@fabpotfabpot mentioned this pull requestOct 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@fredericlesueurs@carsonbot@fabpot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp