Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] remove final from BackedEnumNormalizer#47296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
dehbka wants to merge1 commit intosymfony:6.2fromdehbka:remove-final-from-backed-enum-normalizer
Closed

[Serializer] remove final from BackedEnumNormalizer#47296

dehbka wants to merge1 commit intosymfony:6.2fromdehbka:remove-final-from-backed-enum-normalizer

Conversation

@dehbka
Copy link

@dehbkadehbka commentedAug 17, 2022•
edited
Loading

QA
Branch?6.1
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

Cant use with ProxyManager\ProxyGenerator for doctrine
image

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@dehbkadehbka changed the base branch from6.2 to6.1August 17, 2022 11:07
@dehbkadehbka changed the titleremove final from BackedEnumNormalizer[Serializer] remove final from BackedEnumNormalizerAug 17, 2022
@dehbkadehbka changed the base branch from6.1 to6.2August 17, 2022 12:31
@chalasr
Copy link
Member

Given this service has no dependency, it is trivial to instantiate. What's the point of proxying it?

derrabus reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestAug 17, 2022
This PR was merged into the 5.4 branch.Discussion----------Add missing types to BackedEnumNormalizer| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Spotted while reviewing#47296Not sure why we missed adding them in#40830 🤷Commits-------60d6325 [Serializer] Add missing types to BackedEnumNormalizer
@carsonbotcarsonbot changed the title[Serializer] remove final from BackedEnumNormalizerremove final from BackedEnumNormalizerAug 17, 2022
@carsonbotcarsonbot changed the titleremove final from BackedEnumNormalizer[Serializer] remove final from BackedEnumNormalizerAug 17, 2022
@fabpot
Copy link
Member

I agree with@chalasr.

@fabpotfabpot closed thisAug 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

5 participants

@dehbka@carsonbot@chalasr@fabpot@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp