Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] prevent incomplete profile dumps#47281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedAug 15, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
fabpot commentedAug 19, 2022
This should be for 4.4 as the referenced PR was merged in 4.4, right? |
DennisBirkholz commentedAug 20, 2022
Right, this should be for all versions#46931 was merged into. We currently use 5.4 so I referenced only that version. |
nicolas-grekas commentedAug 30, 2022
In#47435, I propose to add a lock instead. |
nicolas-grekas commentedAug 31, 2022
Closing in favor of#47435, which should provide a bit better experience when race conditions happen. |
Uh oh!
There was an error while loading.Please reload this page.
Write profile dump into tempfile and rename it after it is completely written to prevent loading incomplete profile dumps.