NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] Support for custom handler method containing a Union type tagged with #[AsMessageHandler]#47227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.1fromArchitectNate:fix-47206

Sep 13, 2022

Merged

[Messenger] Support for custom handler method containing a Union type tagged with #[AsMessageHandler]#47227

fabpot merged 1 commit intosymfony:6.1fromArchitectNate:fix-47206

Sep 13, 2022

Conversation

Copy link

Contributor

ArchitectNate commentedAug 9, 2022

Q	A
Branch?	6.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#47206
License	MIT
Doc PR	No

When Union Types were implemented for the #[AsMessageHandler] attribute, it wasn't designed with non__invoke methods in mind.

This fix detects if we are using__invoke or not and constructs the return to match the rest of the logic, mainly it allows for atype => methodName map if__invoke is not being used.

carsonbot added Status: Needs Review Bug Messenger labels

Aug 9, 2022

carsonbot added this to the6.1 milestone

Aug 9, 2022

Copy link

carsonbot commentedAug 9, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

ContributorAuthor

ArchitectNate commentedAug 9, 2022

For the unit test, I tried to reuse the messages that were there but ultimately had to create new dummy messages. Let me know if I need to adjust any of these semantic things

ArchitectNate changed the title~~[Messenger] Support for custom handler method using #[AsMessageHandler] containing a Union type~~[Messenger] Support for custom handler method containing a Union type tagged with #[AsMessageHandler]

Aug 9, 2022