NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mime] Re-allow addIdHeader to be used for 'In-Reply-To' and 'References' headers#47225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.2fromAlbinoDrought:feature/44732-reallow-idheader

Aug 10, 2022

Merged

[Mime] Re-allow addIdHeader to be used for 'In-Reply-To' and 'References' headers#47225

fabpot merged 1 commit intosymfony:6.2fromAlbinoDrought:feature/44732-reallow-idheader

Aug 10, 2022

Conversation

Copy link

Contributor

AlbinoDrought commentedAug 8, 2022

Q	A
Branch?	6.2
Bug fix?	no (arguable: undo BC break)
New feature?	yes (arguable: undo BC break)
Deprecations?	no
Tickets	Fix#45097
License	MIT
Doc PR	symfony/symfony-docs#...

#44732 causes messages usingaddIdHeader('In-Reply-To', ...) oraddIdHeader('References', ...) to fail the headers check (see#44732 (comment) ), requiring users to manually format the header value themselves.

This PR re-allows the previous behaviour ofaddIdHeader while keeping the new unstructured behaviour in-place as the default.

(I'm not sure if this counts as a new feature or a bug fix since it "reintroduces" a previous feature)

carsonbot added Status: Needs Review Feature Mime labels

Aug 8, 2022

carsonbot added this to the6.2 milestone

Aug 8, 2022

Copy link

carsonbot commentedAug 8, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot