Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Fallback looking for DiscriminatorMap on interfaces#47221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedAug 8, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedAug 8, 2022
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
carsonbot commentedNov 24, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedNov 24, 2022
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
02697d6 to83bd108Comparederrabus commentedNov 28, 2022
Hello. Sorry nobody has picked up your PR yet. I have to ask you to provide a test for your change. This helps a reviewer understand the problem that you're attempting to fix. The test also makes sure, your bug is not re-introduced by accident. |
83bd108 toed8336fCompareCaligone commentedNov 29, 2022
No worries |
ed8336f to5333c6dCompare
mtarld left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Almost good!
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bridge/Doctrine/Tests/Middleware/Debug/MiddlewareTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Serializer/Tests/Fixtures/DummyMessageNumberThree.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Serializer/Tests/Fixtures/DummyMessageNumberThree.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
mtarld commentedSep 1, 2023
As it's an old bug, could you target the |
5333c6d tof282ca2Compare…ent object also extends from a class
f282ca2 tobfc4bddCompareCaligone commentedSep 2, 2023
Thanks for the feedback ! |
fabpot commentedSep 10, 2023
Thank you@Caligone. |
Uh oh!
There was an error while loading.Please reload this page.
First time here
Trying to properlyfix#47219 but I'm not sure about the impact of this changes
I am also not sure either if it should be a 6.2 or 6.1 based branch