NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] fix writes to static $kernel property#47195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

xabbuh merged 1 commit intosymfony:4.4fromxabbuh:issue-47186

Aug 5, 2022

Merged

[FrameworkBundle] fix writes to static $kernel property#47195

xabbuh merged 1 commit intosymfony:4.4fromxabbuh:issue-47186

Aug 5, 2022

Conversation

Copy link

Member

xabbuh commentedAug 5, 2022

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#47186
License	MIT
Doc PR

fix writes to static $kernel property

458e0aa

xabbuh added this to the4.4 milestone

Aug 5, 2022

carsonbot added Status: Needs Review Bug FrameworkBundle labels

Aug 5, 2022

xabbuh mentioned this pull request

Aug 5, 2022

KerneltestCase: Discrepancy betweenself::$kernel andstatic::$kernel#47186

Closed

nicolas-grekas approved these changes

Aug 5, 2022

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 5, 2022

Copy link

Contributor

flack commentedAug 5, 2022

I tested this patch against my 4.4 app, and it fixes the issue mentioned in#47186

derrabus approved these changes

Aug 5, 2022

View reviewed changes

xabbuh merged commit675756f intosymfony:4.4

Aug 5, 2022

xabbuh deleted the issue-47186 branch

August 5, 2022 09:29

Copy link

Contributor

flack commentedAug 8, 2022

Pleas note that the problem also exists in newer Symfony versions, e.g.:

symfony/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php

Lines 74 to 77 ind404246

	self::$kernel =$kernel;
	static::$booted =true;

	returnstatic::$kernel;

Should I open a separate ticket for forward ports?

Copy link

MemberAuthor

xabbuh commentedAug 8, 2022

As I do not understood how this change here is related to forward ports it seems indeed to be better to open a new issue that describes what you have in mind. :)

Copy link

Contributor

Sorry, I'm not sure is forward ports is actually a word, I meant it as the opposite of backports (because this is how you do in Symfony, right? You merge to the lowest branch and then you port forwards from there).

What I meant to say was the confusion betweenself::$kernel andstatic::$kernel also exists in newer branches, including 6.2. So the reproduction code in#47186 (or something similar) would also produce an error on these newer branches

Copy link

MemberAuthor

xabbuh commentedAug 8, 2022

Oh, I completely misunderstood your previous comment then. :) I was thinking in terms of forwarded ports when using an HTTP proxy. 😄 I have now merged everything up into the6.2 branch.