Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Add a way to inject Stamps when sending an email via Messenger#47191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
derrabus approved these changesAug 4, 2022
The test failure looks related though. |
Merged
This was referencedOct 25, 2022
fabpot added a commit that referenced this pull requestOct 26, 2022
This PR was merged into the 6.2 branch.Discussion----------[Mailer] Fix BC breaking event name change| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#47989,Fix#47383| License | MIT| Doc PR | -While I get the motivation for introducing this `QueuingMessageEvent` child event in#47191, it's a BC break that is difficult to circumvent due to the fact it's an event (the parent may still be used as it's not deprecated).So I propose to revert its addition and just add the needed stamp-related methods to the original event instead.Commits-------cb64938 [Mailer] Fix BC breaking event name change
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In#47190, we add a way to add a specific stamp to the message sent to the Messenger bus.
I think we should make this possibility more generic.