NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Validator] Add additional hint when`egulias/email-validator` needs to be installed#47189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4frommpdude:patch-5

Aug 5, 2022

Merged

[Validator] Add additional hint when`egulias/email-validator` needs to be installed#47189

fabpot merged 1 commit intosymfony:4.4frommpdude:patch-5

Aug 5, 2022

Conversation

Copy link

Contributor

mpdude commentedAug 4, 2022

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

When using theSymfony\Component\Validator\Constraints\Email constraint with'mode' => 'strict', a helpful error message is shown when the necessary package is not installed.

However, when configuringstrict mode as a framework setting (https://symfony.com/doc/current/reference/configuration/framework.html#email-validation-mode) and omitting themode setting on the constraint itself, that message was missing.

[Validator] Hint thategulias/email-validator needs to be installed…

3924498

… for strict mode as default config

carsonbot added Status: Needs Review Bug Validator labels

Aug 4, 2022

carsonbot added this to the4.4 milestone

Aug 4, 2022

Copy link

Member

xabbuh commentedAug 4, 2022

What about also performing this check in the configuration itself?

Copy link

ContributorAuthor

That might throw the exception also when thestrict setting is only set in configuration, but never actually used. We might do it that way, but it would behave different from settingstrict as an option only... which is why I chose to do it that way here.