Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Deprecate\Stringable support inInputBag#47087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
83287db toda8fb96Compareda8fb96 tob854ba4Comparenicolas-grekas commentedJul 28, 2022
Personally I wouldn't merge this PR: this serves no practical purpose to me. I understand the motivation: InputBag represents values that can be found in request payloads, and these can only be strings or array of strings. To me, this ship has sailed: yes, we could deprecate all non-string values, since none of them are possible values in raw HTTP. Yet, this would plan for a BC break that I don't see the value of. |
fabpot commentedJul 28, 2022
Then, my recommendation would be to deprecate this class altogether as it's not about HTTP anymore, it's just a bag of things. |
nicolas-grekas commentedJul 28, 2022
Deprecating InputBag would require us to use ParameterBag, which is even less strict. The reason why we introduced InputBag was to behave properly when ppl submit Another idea might be to deprecate the To me,#46957 is all that we need on this topic: it fixes a badly removed BC layer. |
chalasr commentedJul 28, 2022
While working on this, I felt this it is not worth the noise it does. I agree with Nicolas we'd probably better not change anything |
nicolas-grekas commentedJul 29, 2022
Let's close then :) |
Uh oh!
There was an error while loading.Please reload this page.
As discussed in#46957, it seems there is no valid use case for using
\Stringableobjects with InputBag.