Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] Fix inline parts when added via attachPart()#46963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fabpot
Copy link
Member

@fabpotfabpot commentedJul 17, 2022•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFixes#42921, Refs#46962
LicenseMIT
Doc PRn/a

}
$attachmentParts[] =$this->createDataPart($attachment);

if ('inline' ===$dispositionRef->getValue($part)) {
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now, we always inline files when set explicitly as inline.

@flack
Copy link
Contributor

I tested this against 5.4.10, and it seems to fix the issue mentioned in#43255

@fabpotfabpotforce-pushed themime-attached-inline-part-not-related branch frome292247 toaeab24aCompareJuly 19, 2022 06:59
@fabpotfabpot merged commit52a2eab intosymfony:4.4Jul 19, 2022
@fabpotfabpot deleted the mime-attached-inline-part-not-related branchJuly 19, 2022 08:55
@xabbuhxabbuh mentioned this pull requestJul 29, 2022
fabpot added a commit that referenced this pull requestJul 29, 2022
This PR was merged into the 6.2 branch.Discussion----------[Mailer] re-add test| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |This test was initially added in#46211 but failed because of the changes from#46963 that were merged in the meantime. The test was then removed ine54dd38. This is a fixed version that is passing again.Commits-------1026e16 re-add test
This was referencedJul 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@fabpot@flack@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp