Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpFoundation] Fix\Stringable support inInputBag::get()#46957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.0fromchalasr:inputbag-get-stringable
Jul 22, 2022

Conversation

@chalasr
Copy link
Member

QA
Branch?6.0
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Spotted in#46936 (comment), thanks@fritzmg.

@chalasrchalasrforce-pushed theinputbag-get-stringable branch from3a80769 to6dfe92eCompareJuly 16, 2022 20:54
@chalasrchalasr changed the base branch from6.2 to6.0July 16, 2022 20:54
@chalasrchalasr modified the milestones:6.2,6.0Jul 16, 2022
@chalasr
Copy link
MemberAuthor

@fabpot Please close if we don't want to fix that inconsistency :)

@fabpot
Copy link
Member

I still don't get the use case to be very honest (get and set).

@chalasr
Copy link
MemberAuthor

That was meant to be temporary à priori, but we can't make it stop as a bugfix. So I'd say this can be merged, and we can deprecate the \Stringable support for bothget andset on 6.2 (I can do the PR later in the weekend).

@fabpot
Copy link
Member

If we deprecate it in 6.2, let's not merge this PR.

@fritzmg
Copy link
Contributor

If we deprecate it in 6.2, let's not merge this PR.

But thenset andget stay inconsistent in 6.x? I do not understand why you do not want to fix this.

@fabpot
Copy link
Member

Because we don't want people to use it as we will deprecate the feature in 6.2.

@chalasr
Copy link
MemberAuthor

The thing is that it works on 5.4, so anyone relying on this will have their code breaks when upgrading to 6.x.
Probably not a big deal so let's reconsider if someone complains about it

@fabpot
Copy link
Member

Oh, I didn't remember that it used to work on 5.4. Let's merge then, but let's not forget the 6.2 PR to deprecate this.

@fabpotfabpot reopened thisJul 22, 2022
@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit36aabb2 intosymfony:6.0Jul 22, 2022
@chalasrchalasr deleted the inputbag-get-stringable branchJuly 22, 2022 16:43
This was referencedJul 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot left review comments

+2 more reviewers

@ro0NLro0NLro0NL left review comments

@fritzmgfritzmgfritzmg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@fabpot@fritzmg@ro0NL@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp