Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Fix\Stringable support inInputBag::get()#46957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
83130b6 to3a80769Compare3a80769 to6dfe92eCompareUh oh!
There was an error while loading.Please reload this page.
chalasr commentedJul 22, 2022
@fabpot Please close if we don't want to fix that inconsistency :) |
fabpot commentedJul 22, 2022
I still don't get the use case to be very honest (get and set). |
chalasr commentedJul 22, 2022
That was meant to be temporary à priori, but we can't make it stop as a bugfix. So I'd say this can be merged, and we can deprecate the \Stringable support for both |
fabpot commentedJul 22, 2022
If we deprecate it in 6.2, let's not merge this PR. |
fritzmg commentedJul 22, 2022
But then |
fabpot commentedJul 22, 2022
Because we don't want people to use it as we will deprecate the feature in 6.2. |
chalasr commentedJul 22, 2022
The thing is that it works on 5.4, so anyone relying on this will have their code breaks when upgrading to 6.x. |
fabpot commentedJul 22, 2022
Oh, I didn't remember that it used to work on 5.4. Let's merge then, but let's not forget the 6.2 PR to deprecate this. |
fabpot commentedJul 22, 2022
Thank you@chalasr. |
Spotted in#46936 (comment), thanks@fritzmg.