Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Allow to specifynull for exception mapping configuration values#46956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@andrew-demb
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

null should be allowed because it is stated as allowed in the configuration info [1][2]
Marked as bugfix due to an existing mismatch between config description and behavior.

[1]

->scalarNode('log_level')
->info('The level of log message. Null to let Symfony decide.')

[2]
->scalarNode('status_code')
->info('The status code of the response. Null to let Symfony decide.')

@andrew-dembandrew-dembforce-pushed theallow-omit-exception-mapping-value branch fromee0f479 to26d12aaCompareJuly 28, 2022 10:00
@andrew-demb
Copy link
ContributorAuthor

Rebased on the latest5.4 to resolve CI failures with doctrine deprecations

@carsonbotcarsonbot changed the titleAllow to specifynull for exception mapping configuration values[FrameworkBundle] Allow to specifynull for exception mapping configuration valuesSep 28, 2022
@andrew-dembandrew-dembforce-pushed theallow-omit-exception-mapping-value branch from26d12aa toc1d5da3CompareSeptember 30, 2022 08:01
protected$exceptionsMapping;

/**
* @param array<class-string, array{log_level: string|null, status_code: int<100,599>|null}> $exceptionsMapping
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it welcome to explicitly specify typing for mapping structure in Symfony codebase for now?

nicolas-grekas reacted with thumbs up emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All good on my side, thanks.

andrew-demb reacted with thumbs up emoji
@fabpotfabpotforce-pushed theallow-omit-exception-mapping-value branch frombcd9033 to1de8f3aCompareSeptember 30, 2022 15:53
@fabpot
Copy link
Member

Thank you@andrew-demb.

@fabpotfabpot merged commit2852cdb intosymfony:5.4Sep 30, 2022
@andrew-dembandrew-demb deleted the allow-omit-exception-mapping-value branchSeptember 30, 2022 15:55
This was referencedOct 12, 2022
@fabpotfabpot mentioned this pull requestOct 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@andrew-demb@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp