Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] ChoiceType choices must support TranslatableInterface#46946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:6.2fromalamirault:46902-support-translatable-interface-choice-typeJul 20, 2022
Merged
[Form] ChoiceType choices must support TranslatableInterface#46946
fabpot merged 1 commit intosymfony:6.2fromalamirault:46902-support-translatable-interface-choice-typeJul 20, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
carsonbot commentedJul 15, 2022
Hey! I think@alexandre-daubois has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Member
xabbuh commentedJul 19, 2022
👍 for me as a new feature in 6.2 @alamirault Can you please also add a changelog entry? |
3ab4d9a tocffb4dfCompareContributorAuthor
alamirault commentedJul 19, 2022
@xabbuh Target is now 6.2 (Failed tests are not related) |
xabbuh approved these changesJul 20, 2022
fabpot approved these changesJul 20, 2022
Member
fabpot commentedJul 20, 2022
Thank you@alamirault. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Before this PR only
TranslatableMessagewas supported in ChoiceView/ChoiceType choices labels.Now
TranslatableInterfacecontract is supported.