Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] MakeAbstractController::render() able to deal with forms and deprecaterenderForm()#46854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
With this change the API becomes implicit and too magical, 👎 from me. |
I suggested this change and I think it makes a lot of sense. The current method looks weird to me as it does not render a form ; it’s very confusing. |
I see the point, maybe better phpdoc blocks would help describing what these methods do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
After discussing with Nicolas, I admit I was already -1 on the previous implementation, so it might be better this way indeed.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
UPGRADE note missing :)
UPGRADEd |
…th forms and deprecate `renderForm()`
No need for
AbstractController::renderForm()whenAbstractController::render()can do it!