Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarExporter] Fix instanciation test on PHP 8.2 with readonly properties#46851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
alexandre-daubois wants to merge1 commit intosymfony:6.2fromalexandre-daubois:fix/varexporter-82-test
Closed
[VarExporter] Fix instanciation test on PHP 8.2 with readonly properties#46851
alexandre-daubois wants to merge1 commit intosymfony:6.2fromalexandre-daubois:fix/varexporter-82-test
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedJul 5, 2022
Thanks for having a look. That's not the right fix. The issue is that readonly props should never be bound by reference and hydrators do that right now. I fixed the issue in#46751 already. |
MemberAuthor
alexandre-daubois commentedJul 5, 2022
Alright, thank you for the explanation@nicolas-grekas 🙏 ! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/Symfony/Component/VarExporter/Tests/InstantiatorTest::testInstantiatefails on PHP 8.2, on Symfony 6.2 only.This fails because of an initialization of a readonly property outside of its class scope (see:https://php.watch/versions/8.1/readonly#init)