Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Provide string keys when iterating on a form#46813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromVincentLanglet:formIteratorKeys
Jul 3, 2022

Conversation

@VincentLanglet
Copy link
Contributor

QA
Branch?6.2 as recommended by#46698 (comment)
Bug fix?no (?)
New feature?no
Deprecations?no
TicketsFix#46698
LicenseMIT
Doc PRsymfony/symfony-docs#...

cc@derrabus

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJul 1, 2022•
edited
Loading

We'd rather patchOrderedHashMap andOrderedHashMapIterator to makethem cast to string. I'd also remove the template onTKey and declare it to be alwaysstring.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks much cleaner thanks :)
Here are some nitpickings.
Please check fabbot also (please ignore the "exception message formatting")

@fabpot
Copy link
Member

Thank you@VincentLanglet.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

+1 more reviewer

@HeahDudeHeahDudeHeahDude left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

FormInterface is reported as\Traversable<string, FormInterface> but can return int as key.

7 participants

@VincentLanglet@nicolas-grekas@fabpot@stof@xabbuh@HeahDude@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp