Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Initially set user null.#46766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.1frommogilvie:patch-1
Jun 25, 2022
Merged

Initially set user null.#46766

fabpot merged 1 commit intosymfony:6.1frommogilvie:patch-1
Jun 25, 2022

Conversation

@mogilvie
Copy link
Contributor

@mogilviemogilvie commentedJun 24, 2022•
edited
Loading

getUser is ?UserInterface return, but throws unset user exception.

Typed property Symfony\Component\Security\Core\Exception\AccountStatusException::$user must not be accessed before initialization

QA
Branch?6.1 for bug fixes
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix null initialization error on getUser
LicenseMIT
Doc PRsymfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuhxabbuh modified the milestones:6.2,6.1Jun 24, 2022
getUser is ?UserInterface return, but throws unset user exception.Typed property Symfony\Component\Security\Core\Exception\AccountStatusException::$user must not be accessed before initialization
@fabpot
Copy link
Member

Thank you@mogilvie.

@fabpotfabpot merged commitd790f00 intosymfony:6.1Jun 25, 2022
@fabpotfabpot mentioned this pull requestJun 26, 2022
@mogilviemogilvie deleted the patch-1 branchOctober 6, 2022 17:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixx

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

5 participants

@mogilvie@carsonbot@fabpot@stof@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp