Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Intl] Fix the IntlDateFormatter::formatObject signature#46730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The same PR should be submitted tohttps://github.com/symfony/polyfill which is the new location of that code for Symfony 5+ |
stof approved these changesJun 21, 2022
GromNaN approved these changesJun 22, 2022
fabpot approved these changesJun 22, 2022
OskarStark approved these changesJun 22, 2022
Thank you@damienalexandre. |
This was referencedJun 26, 2022
Merged
Merged
Merged
Merged
stof added a commit to symfony/polyfill that referenced this pull requestSep 27, 2022
…mienalexandre)This PR was merged into the 1.26-dev branch.Discussion----------[Intl] Fix the IntlDateFormatter::formatObject signatureFollowing bug fix on Symfony Intl component, seesymfony/symfony#46730 for the full description.Commits-------6a35083 [Intl] Fix the IntlDateFormatter::formatObject signature
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was calling
IntlDateFormatter::formatObjectin my user-land code and got this error from PHPStan:The Intl component
formatObjectmethod signature is indeed non-static, but the PHP Intl signature is.Reference:https://www.php.net/manual/en/intldateformatter.formatobject.php
So I think the component should respect PHP method signature.