Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Deprecate OhMySmtp Transport, Create MailPace transport#46714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Holicz wants to merge0 commits intosymfony:6.2fromHolicz:mailpace-transport
Closed

[Mailer] Deprecate OhMySmtp Transport, Create MailPace transport#46714

Holicz wants to merge0 commits intosymfony:6.2fromHolicz:mailpace-transport

Conversation

@Holicz
Copy link
Contributor

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?yes
TicketsFix#46340
LicenseMIT
Doc PRsymfony/symfony-docs#16896

OhMySMTP duplicate was created and renamed to MailPace. OhMySMTP was deprecated.

Copy link
Member

@welcoMatticwelcoMattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, thank you@Holicz. I have added some notes

@Holicz
Copy link
ContributorAuthor

All comments were taken into account.

PS: What is the process for this? Should I resolve the comments when I push the changes or should the original author of the comment review the touched code once again and resolve it himself?

Thanks!

@welcoMattic
Copy link
Member

@Holicz you can resolve comment (if needed, we can unresolve it)

Holicz reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@Holicz.

fabpot added a commit that referenced this pull requestJun 25, 2022
… transport (Holicz)This PR was squashed before being merged into the 6.2 branch.Discussion----------[Mailer] Deprecate OhMySmtp Transport, Create MailPace transport| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes| Deprecations? | yes| Tickets       |Fix#46340| License       | MIT| Doc PR        |symfony/symfony-docs#16896OhMySMTP duplicate was created and renamed to MailPace. OhMySMTP was deprecated.Commits-------dd2d6ed [Mailer] Deprecate OhMySmtp Transport, Create MailPace transport
@fabpotfabpot closed thisJun 25, 2022
@fabpot
Copy link
Member

@Holicz Can you submit a PR on symfony/recipes and one for the docs?

@HoliczHolicz deleted the mailpace-transport branchJune 26, 2022 13:40
@Holicz
Copy link
ContributorAuthor

Sure,

Docs:symfony/symfony-docs#16896
Recipes:symfony/recipes#1104

@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@welcoMatticwelcoMatticwelcoMattic left review comments

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[Mailer] Create a new Mailpace Bridge to replace OhMySMTP Bridge

5 participants

@Holicz@welcoMattic@fabpot@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp