Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PhpUnitBridge] Exclude from baseline generation deprecations triggered in legacy test#46711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4frommondrake:exclude-legacy
Jun 19, 2022

Conversation

@mondrake
Copy link
Contributor

QA
Branch?6.1
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#46710
LicenseMIT

@carsonbotcarsonbot added this to the6.1 milestoneJun 18, 2022
@mondrakemondrake changed the titleExclude from baseline generation deprecations triggered in legacy test[PhpUnitBridge] Exclude from baseline generation deprecations triggered in legacy testJun 18, 2022
@nicolas-grekasnicolas-grekas modified the milestones:6.1,5.4Jun 19, 2022
@nicolas-grekas
Copy link
Member

Thank you@mondrake.

@nicolas-grekasnicolas-grekas merged commitf034bf1 intosymfony:5.4Jun 19, 2022
@mondrake
Copy link
ContributorAuthor

Thanks@nicolas-grekas!

However I think we need to adjust some tests that are now failing - how do you usually do that? Revert and fix, new PR, or? Sorry I come from Drupal world, not yet accustomed to Symfony's etiquette.

@mondrakemondrake deleted the exclude-legacy branchJune 20, 2022 08:29
@mondrake
Copy link
ContributorAuthor

Tests will be fixed in#46719 .

@wouterj
Copy link
Member

wouterj commentedJun 20, 2022
edited
Loading

To answer your questions about the "normal process" of failing tests: Normally, we don't merge PRs that cause test failures, but sometimes we missed that a PR introduced new failing tests (I think that's what happened here).

Due to third party changes or other changes when upmerging older versions into newer branches, our branches often have a few failing tests. If you feel like it, we always welcome people submitting a PR to fix failing tests :) Otherwise, a core team member takes care of it (as the branches have to be green before releasing a new version at the end of the month).

mondrake reacted with thumbs up emoji

@mondrake
Copy link
ContributorAuthor

Thanks@wouterj - I see fixes are already under way, so I'll just pause here.

wouterj reacted with thumbs up emoji

This was referencedJun 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@jderussejderusseAwaiting requested review from jderusse

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@mondrake@nicolas-grekas@wouterj@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp