Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Asset] Ignore missing manifest.json files in non-strict mode#46689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
GromNaN commentedJun 15, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This behavior was not modified by#38495: when the manifest file does not exist, the asset helper always throws an exception (already in4.4). Personally, I enable strict mode on all environments. So yes, the What is the point of requiring |
nicolas-grekas commentedJun 16, 2022
The webapp pack experience is plain broken right now, we cannot afford to wait for 6.2 to fix it. |
nicolas-grekas commentedJun 16, 2022
/cc@weaverryan |
GromNaN commentedJun 16, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
An other alternative would be to create an empty manifest.json file 🙄. But not installing |
weaverryan commentedJun 17, 2022
I think we don't include Encore - so mergesymfony/webapp-pack#7 . Running Even if try to include Encore, but without an error, it's not super useful. It would do nothing until you ran the npm/yarn commands. So if you already will need to run some commands, probably |
nicolas-grekas commentedJun 18, 2022
Closing in favor ofsymfony/webapp-pack#7 |
Something we missed in#38495 I suppose.
In its current state, the webapp-pack cannot be used without running
yarn encore devor similar: as soon as one uses the{{ asset() }}helper in a Twig file, an exception is thrown because themanifest.jsonfile is missing.Similar tosymfony/recipes#1087, we should instead ignore when this file is missing by default, in non-strict mode only of course.